Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused rendered field from Diagnostic struct #108

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Remove unused rendered field from Diagnostic struct #108

merged 1 commit into from
Mar 21, 2018

Conversation

messense
Copy link
Contributor

No description provided.

@messense messense mentioned this pull request Mar 15, 2018
@messense
Copy link
Contributor Author

error: linking with gcc failed: exit code: 1
|
= note: "gcc" "-Wl,--enable-long-section-names" "-fno-use-linker-plugin" "-Wl,--nxcompat" "-nostdlib" "-m64" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib\dllcrt2.o" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib\rsbegin.o" "-L" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive0.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive1.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive10.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive11.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive12.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive13.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive14.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive15.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive2.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive3.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive4.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive5.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive6.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive7.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive8.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.serde_derive9.rcgu.o" "-o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.dll" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.crate.metadata.rcgu.o" "C:\projects\compiletest-rs\target\debug\deps\serde_derive-9ebadb45ca9eec02.crate.allocator.rcgu.o" "-Wl,--gc-sections" "-nodefaultlibs" "-L" "C:\projects\compiletest-rs\target\debug\deps" "-L" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib" "-Wl,-Bstatic" "C:\projects\compiletest-rs\target\debug\deps\libserde_derive_internals-555f0e717120011b.rlib" "C:\projects\compiletest-rs\target\debug\deps\libsyn-9d73a1b0d8b88639.rlib" "C:\projects\compiletest-rs\target\debug\deps\libquote-cce34627b501f031.rlib" "C:\projects\compiletest-rs\target\debug\deps\libproc_macro2-73d79182fd654d90.rlib" "C:\projects\compiletest-rs\target\debug\deps\libunicode_xid-25214f6da763bedd.rlib" "-L" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib" "-Wl,-Bdynamic" "-l" "proc_macro-93dbabd980fbabf9" "-L" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib" "-l" "syntax-031c8126770b77bb" "-L" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib" "-l" "rustc_errors-f2eda81f3e9dcbb7" "-L" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib" "-l" "syntax_pos-f46872503870f814" "-L" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib" "-l" "rustc_data_structures-c0d56ce5645d455f" "-L" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib" "-l" "serialize-60f2dac169f8734f" "-L" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib" "-l" "rustc_cratesio_shim-ce4463286aac2a73" "-L" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib" "-l" "std-6b18c18bbc608054" "-Wl,-Bstatic" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib\libcompiler_builtins-362c10b9d34fdd8e.rlib" "-Wl,-Bdynamic" "-l" "kernel32" "-l" "credui" "-l" "setupapi" "-l" "user32" "-l" "secur32" "-l" "advapi32" "-l" "winspool" "-l" "msimg32" "-l" "gdi32" "-l" "opengl32" "-l" "kernel32" "-l" "dbghelp" "-l" "advapi32" "-l" "ws2_32" "-l" "userenv" "-l" "shell32" "-shared" "-lmingwex" "-lmingw32" "-lgcc" "-lmsvcrt" "-lmsvcrt" "-luser32" "-lkernel32" "C:\Users\appveyor\.rustup\toolchains\nightly-x86_64-pc-windows-gnu\lib\rustlib\x86_64-pc-windows-gnu\lib\rsend.o"
= note: ld: cannot find -lcredui
ld: cannot find -lsecur32

error: aborting due to previous error
error: Could not compile serde_derive.

Hmm?

@laumann
Copy link
Collaborator

laumann commented Mar 15, 2018

I kicked AppVeyor again.

@laumann
Copy link
Collaborator

laumann commented Mar 15, 2018

Same message though

ld: cannot find -lcredui
ld: cannot find -lsecur32

are we missing some feature flags for serde or is the build environment on AppVeyor incorrectly configured?

@messense
Copy link
Contributor Author

I suspect it's rustc nightly breakage since serde-derive has nothing Windows specific.

@messense
Copy link
Contributor Author

@messense
Copy link
Contributor Author

Filed an issue to rustc: rust-lang/rust#49044

@laumann
Copy link
Collaborator

laumann commented Mar 15, 2018

That's interesting, thanks for looking into it. Just FYI, I'm gone until Sunday evening (extended weekend) and will not be able to give you any feedback until the earliest Sunday night. If you want to move forward with this maybe ask @SergioBenitez for feeback. He should have permissions to merge as well. Otherwise, I'll pick this up again Monday I would expect. (Maybe Sunday, but I won't promise it). Thanks again for your work!

@messense messense closed this Mar 18, 2018
@messense messense reopened this Mar 18, 2018
@messense
Copy link
Contributor Author

Ok, now it's blocked on rust-lang/rust#49125

ld: cannot find -lsynchronization

@messense messense closed this Mar 21, 2018
@messense messense reopened this Mar 21, 2018
@messense
Copy link
Contributor Author

This is ready to merge now.

@laumann laumann merged commit a2d7b76 into Manishearth:master Mar 21, 2018
@laumann
Copy link
Collaborator

laumann commented Mar 21, 2018

Thanks!

@messense messense deleted the remove-rendered branch March 21, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants